On Wed, Oct 23, 2019 at 08:37:48AM +0000, Nicholas Johnson wrote: > } else if (!strncmp(str, "hpmemsize=", 10)) { > - pci_hotplug_mem_size = memparse(str + 10, &str); > + pci_hotplug_mmio_size = > + memparse(str + 10, &str); > + pci_hotplug_mmio_pref_size = > + memparse(str + 10, &str); Does this actually work correctly? The first memparse(str + 10, &str) modifies str so the next call will not start from the correct position anymore. Otherwise the patch looks good to me.