On Mon, Oct 21, 2019 at 1:40 PM Mika Westerberg <mika.westerberg@xxxxxxxxx> wrote: > > Hi Karol, > > Sorry for commenting late, I just came back from vacation. > > On Wed, Oct 16, 2019 at 04:44:49PM +0200, Karol Herbst wrote: > > Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device > > states. > > > > v2: convert to pci_dev quirk > > put a proper technical explanation of the issue as a in-code comment > > v3: disable it only for certain combinations of intel and nvidia hardware > > > > Signed-off-by: Karol Herbst <kherbst@xxxxxxxxxx> > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > Cc: Lyude Paul <lyude@xxxxxxxxxx> > > Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> > > Cc: Mika Westerberg <mika.westerberg@xxxxxxxxx> > > Cc: linux-pci@xxxxxxxxxxxxxxx > > Cc: linux-pm@xxxxxxxxxxxxxxx > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Cc: nouveau@xxxxxxxxxxxxxxxxxxxxx > > --- > > drivers/pci/pci.c | 11 ++++++++++ > > drivers/pci/quirks.c | 52 ++++++++++++++++++++++++++++++++++++++++++++ > > I may be missing something but why you can't do this in the nouveau > driver itself? What do you mean precisely? Move the quirk into nouveau, but keep the changes to pci core?
