On Fri, Aug 16, 2019 at 03:28:04PM +0200, Marek Vasut wrote: > On 8/16/19 3:23 PM, Simon Horman wrote: > > On Fri, Aug 09, 2019 at 07:57:40PM +0200, marek.vasut@xxxxxxxxx wrote: > >> From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > >> > >> In case the "dma-ranges" DT property contains either too many ranges > >> or the range start address is unaligned in such a way that populating > >> the range into the controller requires multiple entries, a situation > >> may occur where all ranges cannot be loaded into the controller. > >> > >> Currently, the driver refuses to probe in such a situation. Relax this > >> behavior, load as many ranges as possible and warn if some ranges do > >> not fit anymore. > > > > What is the motivation for relaxing this? > > U-Boot can fill the ranges in properly now, the list would be longer in > such a case and the driver would fail to probe (because the list is > longer than what the hardware can support). Is this the U-Boot patch you refer to: https://patchwork.ozlabs.org/patch/1129436/ As pci_set_region is called with the same address for PCI and CPU memory this implies there is a 1:1 mapping - therefore I don't see a need for multiple mappings for each DRAM bank. (Also if this controller has a 32 bit limitation, shouldn't this code limit the addresses before calling pci_set_region?). Thanks, Andrew Murray > > -- > Best regards, > Marek Vasut
