On Fri, Oct 18, 2019 at 7:35 AM Andrew Murray <andrew.murray@xxxxxxx> wrote: > > On Wed, Oct 16, 2019 at 03:06:27PM -0500, Rob Herring wrote: > > Convert the Designware host bridge to use the common > > pci_parse_request_of_pci_ranges(). > > > > Cc: Jingoo Han <jingoohan1@xxxxxxxxx> > > Cc: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> > > Cc: Andrew Murray <andrew.murray@xxxxxxx> > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > v2: > > - New patch > > > > .../pci/controller/dwc/pcie-designware-host.c | 28 ++++++------------- > > 1 file changed, 8 insertions(+), 20 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > > index 0f36a926059a..aeec8b65eb97 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > > @@ -319,7 +319,7 @@ int dw_pcie_host_init(struct pcie_port *pp) > > struct device *dev = pci->dev; > > struct device_node *np = dev->of_node; > > struct platform_device *pdev = to_platform_device(dev); > > - struct resource_entry *win, *tmp; > > + struct resource_entry *win; > > struct pci_bus *child; > > struct pci_host_bridge *bridge; > > struct resource *cfg_res; > > @@ -342,31 +342,19 @@ int dw_pcie_host_init(struct pcie_port *pp) > > if (!bridge) > > return -ENOMEM; > > > > - ret = devm_of_pci_get_host_bridge_resources(dev, 0, 0xff, > > - &bridge->windows, &pp->io_base); [...] > > + pp->io_bus_addr = pp->io->start - win->offset; > > + pp->io_base = pci_pio_to_address(pp->io->start); > > Where did io_base come from? This wasn't here before, so why are we setting it > now? It was set in the removed devm_of_pci_get_host_bridge_resources(). Rob
