Re: [RESEND PATCH v3] PCI/AER: Save and restore AER config state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 18, 2019 at 03:01:00PM +0000, Patel, Mayurkumar wrote:
> > On Fri, Oct 18, 2019 at 07:37:29AM -0500, Bjorn Helgaas wrote:
> > > On Fri, Oct 18, 2019 at 11:47:21AM +0300, andriy.shevchenko@xxxxxxxxxxxxxxx wrote:
> > > > On Thu, Oct 17, 2019 at 06:09:08PM -0500, Bjorn Helgaas wrote:
> > > > > On Tue, Oct 08, 2019 at 05:22:34PM +0000, Patel, Mayurkumar wrote:
> > > > > > This patch provides AER config save and restore capabilities. After system
> > > > > > resume AER config registers settings are lost. Not restoring AER root error
> > > > > > command register bits on root port if they were set, disables generation
> > > > > > of an AER interrupt reported by function as described in PCIe spec r4.0,
> > > > > > sec 7.8.4.9. Moreover, AER config mask, severity and ECRC registers are
> > > > > > also required to maintain same state prior to system suspend to maintain
> > > > > > AER interrupts behavior.
> > > >
> > > > > Can you send this as plain text?  The patch seems to be a
> > > > > quoted-printable attachment, and I can't figure out how to decode it
> > > > > in a way "patch" will understand.
> > > >
> > > > I understand that it changes your workflow and probably you won't like,
> > > > though you can use patchwork (either thru web, or directly thru client(s)
> > > > like git pw): https://patchwork.ozlabs.org/patch/1173439/
> > >
> > > I had already tried that and "patch" still thought it was corrupted.
> > > Same thing happens when downloading from lore.kernel.org.  Did you try
> > > it and it worked for you?
> > 
> > Hmm... indeed. patch work recognizes the patch, but fails to validate it...
> > 
> > Original mbox is broken :(
> > https://marc.info/?l=linux-pci&m=157055537210812&w=2&q=mbox
> > 
> > So, here is for sure the problem on the sender's side.
> > Sorry for the noise from me.
> > 
> 
> Sorry my mistake. My mail client seems to have re-formatted this
> patch and removed spaces from the front of untouch lines. I ll fix
> my mail client settigns and resend it in plain text again.

You can always test it by sending the email to yourself to make sure
"git am" can apply it.

Bjorn



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux