On Mon, Sep 30, 2019 at 12:36:22PM -0500, Rob Herring wrote: > On Mon, Sep 30, 2019 at 10:13 AM Andrew Murray <andrew.murray@xxxxxxx> wrote: > > > > On Wed, Sep 25, 2019 at 07:33:35AM -0500, Rob Herring wrote: > > > On Wed, Sep 25, 2019 at 5:24 AM Andrew Murray <andrew.murray@xxxxxxx> wrote: > > > > > > > > On Tue, Sep 24, 2019 at 04:46:21PM -0500, Rob Herring wrote: > > > > > Convert altera host bridge to use the common > > > > > pci_parse_request_of_pci_ranges(). > > > > > > > > > > Cc: Ley Foon Tan <lftan@xxxxxxxxxx> > > > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> > > > > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > > > > Cc: rfi@xxxxxxxxxxxxxxxxxxxxxx > > > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > > > > --- > > > > > > > > @@ -833,9 +800,8 @@ static int altera_pcie_probe(struct platform_device *pdev) > > > > > return ret; > > > > > } > > > > > > > > > > - INIT_LIST_HEAD(&pcie->resources); > > > > > - > > > > > - ret = altera_pcie_parse_request_of_pci_ranges(pcie); > > > > > + ret = pci_parse_request_of_pci_ranges(dev, &pcie->resources, > > > > > > > > Does it matter that we now map any given IO ranges whereas we didn't > > > > previously? > > > > > > > > As far as I can tell there are no users that pass an IO range, if they > > > > did then with the existing code the probe would fail and they'd get > > > > a "I/O range found for %pOF. Please provide an io_base pointer...". > > > > However with the new code if any IO range was given (which would > > > > probably represent a misconfiguration), then we'd proceed to map the > > > > IO range. When that IO is used, who knows what would happen. > > > > > > Yeah, I'm assuming that the DT doesn't have an IO range if IO is not > > > supported. IMO, it is not the kernel's job to validate the DT. > > > > Sure. Is it worth mentioning in the commit message this subtle change > > in behaviour? > > Will do. Hi Rob, I would like to merge this series, are you resending it ? It does not apply to v5.4-rc1, if you rebase it please also update this patch log, as per comments above (I can do it too but if you resend it there is no point). Thanks, Lorenzo
