> -----Original Message-----
> From: Shawn Guo <shawnguo@xxxxxxxxxx>
> Sent: 2019年10月3日 17:11
> To: Xiaowei Bao <xiaowei.bao@xxxxxxx>
> Cc: robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; Leo Li
> <leoyang.li@xxxxxxx>; M.h. Lian <minghuan.lian@xxxxxxx>; Mingkai Hu
> <mingkai.hu@xxxxxxx>; Roy Zang <roy.zang@xxxxxxx>;
> lorenzo.pieralisi@xxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
> bhelgaas@xxxxxxxxxx; Z.q. Hou <zhiqiang.hou@xxxxxxx>
> Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
>
> On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote:
> > Add support for the LS1028a PCIe controller.
> >
> > Signed-off-by: Xiaowei Bao <xiaowei.bao@xxxxxxx>
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>
> > ---
> > v2:
> > - No change.
> > v3:
> > - Reuse the ls2088 driver data structurt.
> > v4:
> > - No change.
> > v5:
> > - No change.
> > v6:
> > - No change.
> >
> > drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c
> > b/drivers/pci/controller/dwc/pci-layerscape.c
> > index 3a5fa26..f24f79a 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> > @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata
> > = { static const struct of_device_id ls_pcie_of_match[] = {
> > { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> > + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
>
> I think you can save this driver change by using "fsl,ls2088a-pcie" as
> compatible fallback like below.
>
> compatible = "fsl,ls1028a-pcie", "fsl,ls2088a-pcie";
Yes, it is ok to do so, but according to the previous code, I think add a new compatible " fsl,ls1028a-pcie " to driver is better.
Thanks
Xiaowei
>
> Shawn
>
> > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> > --
> > 2.9.5
> >
