On Tue, Oct 01, 2019 at 11:07:28AM +0100, Andrew Murray wrote: > Hi Tom, > > Thanks for the patch. > > I'd suggest that you rename the subject of this series to "PCI: cadence: ..." > to be consistent with the existing commit history, e.g. git log > --oneline drivers/pci/controller/pcie-cadence* - you'll also see that you > don't need a full stop at the end, and you ought to also change the tense > of the subject, e.g. Refactor driver to ... > > See comments inline... Andrew, thank you very much for your detailed and thoughtful reviews here and elsewhere. It is a huge help. Bjorn