Re: [PATCH 02/11] of: Make of_dma_get_range() private

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 02/11] of: Make of_dma_get_range() private
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 30 Sep 2019 05:53:43 -0700
Cc: devicetree@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Florian Fainelli <f.fainelli@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Frank Rowand <frowand.list@xxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Marek Vasut <marek.vasut@xxxxxxxxx>, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>, Oza Pawandeep <oza.oza@xxxxxxxxxxxx>, Stefan Wahren <wahrenst@xxxxxxx>, Simon Horman <horms+renesas@xxxxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
In-reply-to: <20190927002455.13169-3-robh@kernel.org>
References: <20190927002455.13169-1-robh@kernel.org> <20190927002455.13169-3-robh@kernel.org>
User-agent: Mutt/1.12.1 (2019-06-15)

> +#ifdef CONFIG_OF_ADDRESS
> +extern int of_dma_get_range(struct device_node *np, u64 *dma_addr,
> +			    u64 *paddr, u64 *size);

No need for the extern here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH 00/11] of: dma-ranges fixes and improvements
  - From: Rob Herring
- [PATCH 02/11] of: Make of_dma_get_range() private
  - From: Rob Herring

Prev by Date: Re: [PATCH 00/11] of: dma-ranges fixes and improvements
Next by Date: Re: [PATCH 03/11] of: address: Report of_dma_get_range() errors meaningfully
Previous by thread: Re: [PATCH 02/11] of: Make of_dma_get_range() private
Next by thread: [PATCH 01/11] of: Remove unused of_find_matching_node_by_address()
Index(es):
- Date
- Thread

[Index of Archives] [DMA Engine] [Linux Coverity] [Linux USB] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Greybus]

Powered by Linux