On Thu, Sep 26, 2019 at 10:29:34AM +0100, Andrew Murray wrote: > Though I'd be just as happy if the csr_[read,write][l,] functions were > renamed to mobiveil_csr_[read,write][l,]. Please do that instead, using such generic names as csr_* in a driver is a bad idea, with or without a __ prefix.