On Thu, Sep 26, 2019 at 08:11:16AM -0500, Rob Herring wrote: > On Thu, Sep 26, 2019 at 6:20 AM Marc Gonzalez <marc.w.gonzalez@xxxxxxx> wrote: > > > > [ Tweaking recipients list ] > > > > On 26/09/2019 10:49, Andrew Murray wrote: > > > > > On Tue, Sep 24, 2019 at 04:46:19PM -0500, Rob Herring wrote: > > > > > >> pci-rcar-gen2 is the only remaining driver doing its own dma-ranges > > >> handling as it is still using the old ARM PCI functions. Looks like it > > >> is the last one (in drivers/pci/). > > > > > > It also seems that pcie-tango is using of_pci_dma_range_parser_init > > > and so parsing dma-ranges. Though it's using the dma_ranges for a > > > slightly different purpose. > > Seems I missed that as I only grep'ed for for_each_of_pci_range... > > > > > The rationale for that code can be found here: > > > > https://patchwork.kernel.org/patch/9915469/ > > > > NB: 1) The PCIE_TANGO_SMP8759 Kconfig symbol is marked "depends on BROKEN", > > and 2) The driver adds TAINT_CRAP, > > and 3) The maker of the tango platform is dead. > Thanks for the context Marc, much appreciated. Is there a path to make this driver not BROKEN? Or is this likely to bit rot? > Given that and that I'd have to rework the probe to do the MSI range > setup after pci_host_common_probe, I'm just going to leave this one > alone. I don't see any harm with that. Thanks, Andrew Murray > > Rob
