On Sun, Sep 1, 2019 at 3:30 PM Remi Pommarel <repk@xxxxxxxxxxxx> wrote: > > Normally asserting reset signal on gpio would be achieved with: > gpiod_set_value_cansleep(reset_gpio, 1); > > Meson PCI driver set reset value to '0' instead of '1' as it takes into > account the PERST# signal polarity. The polarity should be taken care > in the device tree instead. > > This fixes the reset assertion meaning and moves out the polarity > configuration in DT (please note that there is no DT currently using > this driver). > Fixes: 9c0ef6d34fdb ("PCI: amlogic: Add the Amlogic Meson PCIe controller driver") > Signed-off-by: Remi Pommarel <repk@xxxxxxxxxxxx> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>