On Tue, Aug 20, 2019 at 1:48 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > On Tue, Aug 20, 2019 at 12:51:09PM -0700, Rajat Jain wrote: > > > > May be we're digressing now, but I'd like to point out that there is > > atleast one more file in ASPM that potentially violates the "1 value > > per file" rule: > > > > rajatja@rajat2:/sys/module/pcie_aspm/parameters$ cat policy > > [default] performance powersave powersupersave > > rajatja@rajat2:/sys/module/pcie_aspm/parameters$ > > > > ... although I would argue in this case that it makes it much clear > > what are the allowable values to write, and which is the current > > selected one. > > Huh, that's a good point. That "policy" file is a little problematic > for several reasons, one being the config options > (CONFIG_PCIEASPM_PERFORMANCE, CONFIG_PCIEASPM_POWERSAVE, etc) that > lock a distro into some default choice. > > Maybe there's something we can do there, although there's legacy use > to consider (there are a zillion web pages that document > pcie_aspm/parameters/policy as a way to fix things), and it's > certainly beyond the scope of *this* series. Agreed! > > Bjorn
