On Thu, Aug 01, 2019 at 02:21:07PM -0700, sathyanarayanan kuppuswamy wrote: > On 8/1/19 2:09 PM, Keith Busch wrote: > > Rather than surround the call to pci_pri_init() with the #ifdef, you > > should provide an empty function implementation when CONFIG_PCI_PRI is > > not defined. Same thing for the next patch adding PASID. > > This function is defined and used in the same file (ats.c). Is there any > advantage in defining an empty function ? But if this is the recommended > approach, I can make the necessary changes. Please confirm. That way is just the existing convention, so it's recommended for kernel style consistency. See the "Conditional Compilation" section in Documentation/process/coding-style.rst (currently section 21).
