On Sun, 2019-07-21 at 15:08 +0000, Chocron, Jonathan wrote: > > Please sort the variables following the reverse tree order. > > > > Done. > > I'd think that it would make sense to group variables which have a > common characteristic (e.g. resources read from the DT), even if it > mildly breaks the convention (as long as the general frame is longest > to shortest). Does this sound ok? > > BTW, I couldn't find any documentation regarding the reverse-tree > convention, do you have a pointer to some? It's a complete stupidity that people who have nothing better to comment about keep throwing at you when you are trying to get stuff working. Yes, we should avoid ugly stuff such as int rc; struct something_very_long foo; But this definitely should come second to saner ordering such as the one you propose of grouping related things together. At least IMHO. You'll notice that the kernel these days attract way more people interested in commenting to death on various minor points of coding style than actual worthwhile technical comments on the code. Cheers, Ben.
