Hi,
On 05/07/19 10:38 PM, Andy Shevchenko wrote:
> On Fri, Jul 05, 2019 at 05:23:58PM +0100, Lorenzo Pieralisi wrote:
>> On Fri, Jun 28, 2019 at 04:33:26PM +0300, Andy Shevchenko wrote:
>>> The commit c9a707875053 ("tools pci: Do not delete pcitest.sh in 'make clean'")
>>> fixed a `make tools clean` issue and simultaneously brought a regression
>>> to the installation process:
>>>
>>> for script in .../tools/pci/pcitest.sh; do \
>>> install $script .../usr/usr/bin; \
>>> done
>>> install: cannot stat '.../tools/pci/pcitest.sh': No such file or directory
>>>
>>> Here is the missed part of the fix.
>>
>> Sigh, hopefully that's the last fix :), Kishon if that's OK mind
>> ACKing it please ?
>
> From my side, yes. Now it works as I expect.
>
> Honestly, I'm puzzled how so many errors has been pushed upstream...
I'm not sure why, but I don't see any issue without this patch as well. Am I
missing something here? I'm copy pasting the steps below.
a0393678@a0393678ub:~/repos/linux/tools/pci$ make clean
rm -f pcitest
rm -rf include/
find . -name '*.o' -delete -o -name '\.*.d' -delete
a0393678@a0393678ub:~/repos/linux/tools/pci$ make
mkdir -p include/linux/ 2>&1 || true
ln -sf /home/a0393678/repos/linux/tools/pci/../../include/uapi/linux/pcitest.h
include/linux/
make -f /home/a0393678/repos/linux/tools/build/Makefile.build dir=. obj=pcitest
make[1]: Entering directory '/home/a0393678/repos/linux/tools/pci'
CC pcitest.o
LD pcitest-in.o
make[1]: Leaving directory '/home/a0393678/repos/linux/tools/pci'
LINK pcitest
a0393678@a0393678ub:~/repos/linux/tools/pci$ sudo make install
make -f /home/a0393678/repos/linux/tools/build/Makefile.build dir=. obj=pcitest
install -d -m 755 /usr/bin; \
for program in pcitest pcitest.sh; do \
install $program /usr/bin; \
done; \
for script in pcitest.sh; do \
install $script /usr/bin; \
done
a0393678@a0393678ub:~/repos/linux/tools/pci$
Thanks
Kishon
