Re: [PATCH v1 1/2] tools: PCI: Fix compilation error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 05, 2019 at 05:21:47PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 05, 2019 at 02:34:41PM +0100, Lorenzo Pieralisi wrote:
> > On Fri, Jun 28, 2019 at 04:12:17PM +0300, Andy Shevchenko wrote:
> > > The commit
> > > 
> > >   b71f0a0b1e3f ("tools: PCI: Exit with error code when test fails")
> > > 
> > > forgot to update function prototype and thus brought a regression:
> > > 
> > > pcitest.c:221:9: error: void value not ignored as it ought to be
> > >  return run_test(test);
> > >         ^~~~~~~~~~~~~~
> > > 
> > > Fix it by changing prototype from void to int.
> > > 
> > > While here, initialize ret with 0 to avoid compiler warning:
> > > 
> > > pcitest.c:132:25: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> > > 
> > > Fixes: b71f0a0b1e3f ("tools: PCI: Exit with error code when test fails")
> > > Cc: Jean-Jacques Hiblot <jjhiblot@xxxxxx>
> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> > > Cc: Kishon Vijay Abraham I <kishon@xxxxxx>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > >  tools/pci/pcitest.c | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > Patch 1 and 2 already applied from another thread:
> > 
> > https://lore.kernel.org/linux-pci/1558646281-12676-1-git-send-email-alan.mikhak@xxxxxxxxxx/
> > 
> > Thanks anyway !
> 
> I don't see neither in v5.2-rc7, nor in Linux Next.
> In which repository is it?

It is in -next:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/tools/pci/pcitest.c?h=next-20190705



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux