Re: [PATCH] PCI: imx: Allow iMX PCIe driver on iMX6SX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/2/19 3:18 PM, Lucas Stach wrote:
> Hi Marek,
> 
> Am Sonntag, den 30.06.2019, 22:53 +0200 schrieb Marek Vasut:
>> The driver supports iMX6SX, align the Kconfig file with the driver.
> 
> The patch "PCI: Kconfig: Simplify PCI_IMX6 depends on", which will
> hopefully hit mainline pretty soon now after it got lost in the cracks
> of my inbox for far too long, is a more complete solution to the same
> problem.

Is it ? Some of the SoCs where that other patch enables the driver do
not even have a PCIe IP in it, it feels like a heavy-handed approach to me.

>> Signed-off-by: Marek Vasut <marex@xxxxxxx>
>> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
>> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>> Cc: Richard Zhu <hongxing.zhu@xxxxxxx>
>> Cc: Sasha Levin <sashal@xxxxxxxxxx>
>> Cc: Sven Van Asbroeck <TheSven73@xxxxxxxxxxxxxx>
>> Cc: Trent Piepho <tpiepho@xxxxxxxxxx>
>> ---
>>  drivers/pci/controller/dwc/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
>> index a6ce1ee51b4c..3051387bf4f3 100644
>> --- a/drivers/pci/controller/dwc/Kconfig
>> +++ b/drivers/pci/controller/dwc/Kconfig
>> @@ -90,7 +90,7 @@ config PCI_EXYNOS
>>  
>>  config PCI_IMX6
>>  	bool "Freescale i.MX6/7/8 PCIe controller"
>> -	depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST
>> +	depends on SOC_IMX6SX || SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST
>>  	depends on PCI_MSI_IRQ_DOMAIN
>>  	select PCIE_DW_HOST
>>  


-- 
Best regards,
Marek Vasut



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux