On Fri, Jun 21, 2019 at 04:20:24PM +0100, Alan Cox wrote: > On Fri, 21 Jun 2019 15:16:04 +0530 > Puranjay Mohan <puranjay12@xxxxxxxxx> wrote: > > > This patch series removes the private duplicates of PCI definitions in > > favour of generic definitions defined in pci_regs.h. > > Why bother ? It's an ancient obsolete card ? That's a fair question. Is there anything that would indicate that "this file is obsolete and problems shouldn't be fixed"? Nobody wants to waste time on things that don't need to be fixed, but I don't know how to tell if something is obsolete. My naive assumption is that if something is in the tree, it's fair game for fixes and cleanups. Bjorn