On Thu, Jun 13, 2019 at 07:42:43PM +0000, Jason Gunthorpe wrote: > On Thu, Jun 13, 2019 at 11:43:20AM +0200, Christoph Hellwig wrote: > > There isn't really much value add in the hmm_devmem_add wrapper. Just > > factor out a little helper to find the resource, and otherwise let the > > driver implement the dev_pagemap_ops directly. > > Was this commit message written when other patches were squashed in > here? I think the helper this mentions was from an earlier patch Yes, it was written before a lot of bits were split out. I've updated it for the next version.