On Tue, 2019-06-11 at 15:58 +0100, Lorenzo Pieralisi wrote:
>
>
> if (obj && obj->type == ACPI_TYPE_INTEGER && obj->integer.value == 0) {
> /* preserve existing resource assignment */
> pci_bus_claim_resources(bus);
> }
>
> pci_bus_size_bridges(bus);
> pci_bus_assign_resources(bus);
So that makes me nervous... my understanding is that the pair
pci_bus_size_bridges(bus);
pci_bus_assign_resources(bus);
Is intended for full reassignment. Now they will try to skip resources
that already have a parent, but that's yet another code path. What's
wrong with pci_unassigned_* ? That's what it's meant for...
> That's how it should be I think:
>
> 1) we do not want pci_assign_unassigned_root_bus_resources(bus) to
> reallocate resources already claimed (see realloc parameter), do we ?
Well, realloc is useful to handle SR_IOV when the BIOS doesn't do it
right (common case). That said, at this point, we should be able to
honor IORESOURCE_PCI_FIXED for things that have _DSM #5 since they have
been claimed. I don't see that realloc logic being a problem for us,
and I want to avoid gratuitous differences with x86, but maybe I'm
missing something here...
> 2) pci_bus_size_bridges(bus) and pci_bus_assign_resources(bus) should
> not interfere with resources already claimed so it *should* be safe
> to call them anyway
Sure, *should* and here we introduce yet another way of doing things
though... Any reason we don't want to do what x86 does here ?
> Most importantly: I want everyone to agree that claiming is equivalent
> to making a resource immutable (except for realloc, see (1) above)
> because that's what we are doing by claiming on _DSM #5 == 0.
I think the combination of claiming *and* IORESOURCE_PCI_FIXED is what
makes it *really* immutable. I'm a bit confused by the realloc logic
right now, I'll need more quality time looking at it after ingesting
more caffeing but I'm under the impression that it will honor the flag.
> There are too many ways to make a resource immutable in the kernel
> and this is confusing and prone to bugs.
It is, but I don't want to create new ways of doing things, and what
you seem to propose is a new way imho :-)
Cheers,
Ben.
> Thanks,
> Lorenzo
>
> > + ACPI_FREE(obj);
> >
> > list_for_each_entry(child, &bus->children, node)
> > pcie_bus_configure_settings(child);
> > diff --git a/include/linux/pci-acpi.h b/include/linux/pci-acpi.h
> > index 8082b612f561..62b7fdcc661c 100644
> > --- a/include/linux/pci-acpi.h
> > +++ b/include/linux/pci-acpi.h
> > @@ -107,9 +107,10 @@ static inline void acpiphp_check_host_bridge(struct acpi_device *adev) { }
> > #endif
> >
> > extern const guid_t pci_acpi_dsm_guid;
> > -#define DEVICE_LABEL_DSM 0x07
> > -#define RESET_DELAY_DSM 0x08
> > -#define FUNCTION_DELAY_DSM 0x09
> > +#define IGNORE_PCI_BOOT_CONFIG_DSM 0x05
> > +#define DEVICE_LABEL_DSM 0x07
> > +#define RESET_DELAY_DSM 0x08
> > +#define FUNCTION_DELAY_DSM 0x09
> >
> > #else /* CONFIG_ACPI */
> > static inline void acpi_pci_add_bus(struct pci_bus *bus) { }
> >
> >
