On Tue, Apr 23, 2019 at 02:58:25PM +0530, Manikanta Maddireddy wrote:
> Driver checks for link up three times before giving up, each retry attempt
> is printed as an error. Letting users know that PCIe link is down and in the
> process of being brought up again is informational, not an error condition.
>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx>
> ---
> V2: Updated commit log
>
> drivers/pci/controller/pci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I wonder if we even need the informational message at all. Is there any
information in there that's useful to know? Do we care about how often
the link-up was tried if it ends up being brought up in the end?
Thierry
>
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 09b3b3e847c5..563958104dd0 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -2370,7 +2370,7 @@ static bool tegra_pcie_port_check_link(struct tegra_pcie_port *port)
> } while (--timeout);
>
> if (!timeout) {
> - dev_err(dev, "link %u down, retrying\n", port->index);
> + dev_info(dev, "link %u down, retrying\n", port->index);
> goto retry;
> }
>
> --
> 2.17.1
>
Attachment:
signature.asc
Description: PGP signature
