On Tue, Apr 23, 2019 at 02:58:17PM +0530, Manikanta Maddireddy wrote:
> Tegra signals PCIe services like AER, PME, etc over legacy IRQ line.
> By default, service drivers register interrupt routine over MSI IRQ line.
> Use pcie_pme_disable_msi() function to disable MSI for service drivers.
>
> PME and AER interrupts registered to MSI without this change,
> cat /proc/interrupts | grep -i pci
> 36: 21 0 0 0 0 0 GICv2 104 Level PCIE
> 37: 35 0 0 0 0 0 GICv2 105 Level Tegra PCIe MSI
> 76: 0 0 0 0 0 0 Tegra PCIe MSI 0 Edge PCIe PME, aerdrv, PCIe BW notif
>
> PME and AER interrupts registered to legacy IRQ with this change,
> cat /proc/interrupts | grep -i pci
> 36: 33 0 0 0 0 0 GICv2 104 Level PCIE, PCIe PME, aerdrv, PCIe BW notif
> 37: 52 0 0 0 0 0 GICv2 105 Level Tegra PCIe MSI
>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx>
> ---
> V2: No change
>
> drivers/pci/controller/pci-tegra.c | 4 ++++
> 1 file changed, 4 insertions(+)
I think I mentioned this before, but it would be nice to make this
setting per-controller rather than system-global. In practice I guess
this doesn't really matter at this point, and I'm not sure how much
Bjorn cares, so:
Acked-by: Thierry Reding <treding@xxxxxxxxxx>
>
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 72634ce6d3da..edc6a0f27397 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -41,6 +41,7 @@
> #include <soc/tegra/pmc.h>
>
> #include "../pci.h"
> +#include "../pcie/portdrv.h"
>
> #define INT_PCI_MSI_NR (8 * 32)
>
> @@ -2721,6 +2722,9 @@ static int tegra_pcie_probe(struct platform_device *pdev)
> goto put_resources;
> }
>
> + /* Switch to legacy IRQ for PCIe services like AER, PME*/
> + pcie_pme_disable_msi();
> +
> pm_runtime_enable(pcie->dev);
> err = pm_runtime_get_sync(pcie->dev);
> if (err) {
> --
> 2.17.1
>
Attachment:
signature.asc
Description: PGP signature
