On Tue, Apr 23, 2019 at 02:58:03PM +0530, Manikanta Maddireddy wrote:
[...]
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
[...]
> + while (ktime_before(ktime_get(), deadline)) {
> + value = readl(port->base + RP_LINK_CONTROL_STATUS);
> + if ((value & PCI_EXP_LNKSTA_LT) == 0)
> + break;
> +
> + usleep_range(2000, 3000);
> + }
> + if (value & PCI_EXP_LNKSTA_LT)
> + dev_warn(dev, "PCIe port %u link is in recovery\n",
> + port->index);
Blank line between "}" and "if (...)" for readability.
> + while (ktime_before(ktime_get(), deadline)) {
> + value = readl(port->base + RP_LINK_CONTROL_STATUS);
> + if ((value & PCI_EXP_LNKSTA_LT) == 0)
> + break;
> +
> + usleep_range(2000, 3000);
> + }
> + if (value & PCI_EXP_LNKSTA_LT)
> + dev_err(dev, "failed to retrain link of port %u\n",
> + port->index);
Same here.
With that:
Acked-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
