On Sun, Apr 14, 2019 at 05:46:21PM -0700, Andrey Smirnov wrote: > Everyone: > > This is the series containing various small improvements that I made > while reading the code and researching commit history of pci-imx6.c > and pcie-designware*.c files. All changes are optional, so commits > that don't seem like an improvement can be easily dropped. Hopefully > each patch is self-explanatory. > > I tested this series on i.MX6Q, i.MX7D and i.MX8MQ. Applied with Lucas' tags to pci/imx, hopefully we can squeeze this in for the v5.2 merge window. Lorenzo > Feedback is welcome! > > Thanks, > Andrey Smirnov > > Chagnes since [v3]: > > - Collected Reviewed-by from Lucas for most of the patches > > - Converted "PCI: imx6: Replace calls to udelay() with > usleep_range()" to "PCI: imx6: Use usleep_range() in > imx6_pcie_enable_ref_clk()" > > - Converted "PCI: imx6: Remove redundant debug tracing" to "PCI: > imx6: Drop imx6_pcie_wait_for_link()" > > - Converted all of the callers of pcie_phy_poll_ack() to use > true/false in "PCI: imx6: Simplify pcie_phy_poll_ack()" > > Changes since [v2]: > > - All non i.MX6 patches dropped, since they were accepted as a > seprarte series > > - Series rebased on latest 'dwc-pci' branch of PCI tree > > - Patches "PCI: imx6: Use flags to indicate support for suspend" > and "PCI: imx6: Replace calls to udelay() with usleep_range()" > added to the series > > Changes since [v1]: > > - Dropped "PCI: imx6: Drop imx6_pcie_link_up()" due to the matter > already having been addressed by "PCI: imx6: Fix link training > status detection in link up check" from Trent Piepho > > - Changed "designware" -> "dwc" for all subject lines > > - Collected Acked-by's from Gustavo Pimentel > > [v3] lkml.kernel.org/r/20190401042547.14067-1-andrew.smirnov@xxxxxxxxx > [v2] lkml.kernel.org/r/20190104174925.17153-1-andrew.smirnov@xxxxxxxxx > [v1] lkml.kernel.org/r/20181221072716.29017-1-andrew.smirnov@xxxxxxxxx > > Andrey Smirnov (11): > PCI: imx6: Simplify imx7d_pcie_wait_for_phy_pll_lock() > PCI: imx6: Drop imx6_pcie_wait_for_link() > PCI: imx6: Return -ETIMEOUT from imx6_pcie_wait_for_speed_change() > PCI: imx6: Remove PCIE_PL_PFLR_* constants > PCI: dwc: imx6: Share PHY debug register definitions > PCI: imx6: Make use of BIT() in constant definitions > PCI: imx6: Simplify bit operations in PHY functions > PCI: imx6: Simplify pcie_phy_poll_ack() > PCI: imx6: Restrict PHY register data to 16-bit > PCI: imx6: Use flags to indicate support for suspend > PCI: imx6: Use usleep_range() in imx6_pcie_enable_ref_clk() > > drivers/pci/controller/dwc/pci-imx6.c | 143 ++++++++----------- > drivers/pci/controller/dwc/pcie-designware.c | 12 +- > drivers/pci/controller/dwc/pcie-designware.h | 3 + > 3 files changed, 62 insertions(+), 96 deletions(-) > > -- > 2.20.1 >