On Mon, Jan 07, 2019 at 01:32:48PM -0800, James Prestwood wrote: > This card has similar issues with bus reset as the others present in > this list. > > Signed-off-by: James Prestwood <james.prestwood@xxxxxxxxxxxxxxx> Alex, I'm inclined to apply this unless you object because it's basically one more of something we already do. I wish we didn't have this quirk at all, but I don't know what else to do. Maybe there's someplace we could add a printk so dmesg contains a clue that we can't reset the device? I assume this quirk means we can't reset the device when we otherwise would, so maybe that means this device will leak state from one VM to another? That sounds like something we would want to surface somehow if we don't already. Bjorn > --- > drivers/pci/quirks.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index ef7143a274e0..d9d4a95b0309 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -3379,6 +3379,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0030, quirk_no_bus_reset); > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0032, quirk_no_bus_reset); > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x003c, quirk_no_bus_reset); > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0033, quirk_no_bus_reset); > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0034, quirk_no_bus_reset); > > /* > * Root port on some Cavium CN8xxx chips do not successfully complete a bus > -- > 2.17.1 >
