On 4/11/2019 3:46 PM, Thierry Reding wrote:
On Fri, Apr 05, 2019 at 01:24:29AM +0530, Vidya Sagar wrote:
Export pcie_pme_disable_msi() API to enable drivers using this API be able to
build as loadable modules
Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
---
Changes from [v1]:
* This is a new patch in v2 series
drivers/pci/pcie/pme.c | 6 ++++++
drivers/pci/pcie/portdrv.h | 5 +----
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
index 54d593d10396..18e815c1e3c9 100644
--- a/drivers/pci/pcie/pme.c
+++ b/drivers/pci/pcie/pme.c
@@ -27,6 +27,12 @@
*/
bool pcie_pme_msi_disabled;
+void pcie_pme_disable_msi(void)
+{
+ pcie_pme_msi_disabled = true;
+}
+EXPORT_SYMBOL_GPL(pcie_pme_disable_msi);
+
static int __init pcie_pme_setup(char *str)
{
if (!strncmp(str, "nomsi", 5))
diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h
index 1d50dc58ac40..2be7b7e9a784 100644
--- a/drivers/pci/pcie/portdrv.h
+++ b/drivers/pci/pcie/portdrv.h
@@ -127,10 +127,7 @@ struct pci_dev;
#ifdef CONFIG_PCIE_PME
extern bool pcie_pme_msi_disabled;
-static inline void pcie_pme_disable_msi(void)
-{
- pcie_pme_msi_disabled = true;
-}
+void pcie_pme_disable_msi(void);
static inline bool pcie_pme_no_msi(void)
{
Perhaps also export pcie_pme_no_msi()? That way you could get rid of the
extern declaration of the pcie_pme_msi_disabled variable and make it
static to drivers/pci/pcie/pme.c?
Agree. I'll take care of this in V3 patch series.
Thierry
