Re: [PATCH for-next 2/2] IB/hfi1: Make Unsupported Request error non-fatal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/12/2019 9:55 AM, Jason Gunthorpe wrote:
On Thu, Apr 11, 2019 at 08:37:53PM +0000, Arumugam, Kamenee wrote:

On Thu, Apr 11, 2019 at 06:22:45PM +0000, Arumugam, Kamenee wrote:

This is a device bug then.

A RDMA device must accept and respond to all TLPs that the CPU could create for the user accessible BAR pages.

A user process must not be able to crash the CPU or make the device malfunction by accessing the exposed BAR page. This includes a broad range of topics, like mis-aligned acceses, SSE instructions, atomics, >etc.

Is blocking AER even enough here? If the device isn't generating a reasonable reply I have a bad feeling worse will happen.

After blocking unsupported request error, we don't see any other issue including no system hang.

Are you specifically testing all the special TLPs the CPU can produce?

All the special TLPs should have been tested. This however seems to be a missed test case. Not that surprising though given differences in BIOS and things of that nature that something falls through the cracks and is extra hard to find.

-Denny




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux