On Thu, Apr 11, 2019 at 05:27:31AM -0700, Joe Perches wrote:
> On Thu, 2019-04-11 at 22:07 +1000, Michael Ellerman wrote:
> > Joe Perches <joe@xxxxxxxxxxx> writes:
> > > On Thu, 2019-04-11 at 06:27 +0200, Lukas Bulwahn wrote:
> > > > Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com
> > > > to @linux.ibm.com in commit 1dfddcdb95c4
> > > > ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but
> > > > some still remained.
> > > >
> > > > We update the remaining email addresses in MAINTAINERS, hopefully finally
> > > > catching all cases for good.
> > >
> > > Perhaps update all the similar addresses in other files too
> > >
> > > $ git grep --name-only 'linux\.vnet\.ibm\.com' | wc -l
> > > 315
> >
> > A good number of them are no longer valid. So I'm not sure it's worth
> > updating them en masse to addresses that won't ever work.
> >
> > We have git now, we don't need email addresses in files, they're just
> > prone to bitrot like this.
> >
> > Should we just change them all like so?
> >
> > -arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxxx>
> > +arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer (IBM)
> >
> > To indicate the author was at IBM when they wrote it?
>
> If that's desired, perhaps:
>
> $ git grep -P --name-only '<?[\w\.]+(?:@| at )linux\.vnet\.ibm\.com>?' | \
> grep -vP '\.mailmap|MAINTAINERS' | \
> xargs perl -p -i -e 's/<?[\w\.]+(?:@|\ at\ )linux\.vnet\.ibm\.com>?/(IBM)/g'
>
> > Or should we try and update them with current addresses? Though then the
> > authors might start getting mails they don't want.
>
> That'd be my preference.
>
> If authors get emails they don't want, then those contact
> emails should be removed.
I have updated most of mine, with one more installment of patches to go
into the next merge window and another into the merge window after that.
More churn than I would have expected, though. If my email address were
to change again, I would instead go with the "(IBM)" approach and let
the git log and MAINTAINERS file keep the contact information. Not that
we get to update the git log, of course. ;-)
I might not have bothered except for combining with the SPDX-tag
commits.
Thanx, Paul
