Hey Bjorn, On 2019-03-04 1:11 p.m., Bjorn Helgaas wrote: > On Mon, Mar 4, 2019 at 1:21 PM Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote: >> On 2019-03-03 5:23 p.m., Bjorn Helgaas wrote: >>> Sorry for the delay. This code gives a headache. I still remember >>> my headache from the last time we touched it. Help me understand >>> what's going on here. >> >> Yes, this code gave me a headache debugging it too. And it's not the >> first time I've tried to figure out what's going on with it because it >> often just prints noisy messages that look like errors. I think I >> understand it better now but it's something that's a bit fleeting and >> easy to forget the details of. There may also be other solutions to this >> problem. > > Thanks for the explanation below. I haven't worked through it yet, but I will. Any chance you've had a chance to go through this issue yet? Is there anything I should do with it? Do you want me to try to improve the commit messages and resend the patches? Thanks, Logan
