Re: [PATCH V2] PCI: rcar: Add the initialization of PCIe link in resume_noirq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/25/19 5:54 PM, Lorenzo Pieralisi wrote:
> On Sun, Feb 17, 2019 at 02:24:41PM +0100, marek.vasut@xxxxxxxxx wrote:
>> From: Kazufumi Ikeda <kaz-ikeda@xxxxxxxxxxxxx>
>>
>> Reestablish the PCIe link very early in the resume process in case it
>> went down to prevent PCI accesses from hanging the bus. Such accesses
>> can happen early in the PCI resume process, in the resume_noirq, thus
>> the link must be reestablished in the resume_noirq callback of the
>> driver.
>>
>> Signed-off-by: Kazufumi Ikeda <kaz-ikeda@xxxxxxxxxxxxx>
>> Signed-off-by: Gaku Inami <gaku.inami.xw@xxxxxxxxxxxxxx>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>> Cc: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
>> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx>
>> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
>> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
>> ---
>> V2: - Use BIT() macro for (1 << n)
>>     - Since polling in rcar_pcie_wait_for_dl() uses udelay(), do not
>>       add extra changes to this function anymore
>>     - Make resume_noirq return early and clean up parenthesis therein
>> ---
>>  drivers/pci/controller/pcie-rcar.c | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
> 
> I applied it to pci/controller-fixes but the kbot barfed at it so we
> need to rework it.

Right, PMSR definition added, updated commit message retained, patch
resubmitted as V3.

-- 
Best regards,
Marek Vasut



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux