On Mon, Mar 25, 2019 at 11:49 AM John Garry <john.garry@xxxxxxxxxx> wrote: > On 23/03/2019 19:12, Andy Shevchenko wrote: > > On Wed, Mar 20, 2019 at 8:14 PM John Garry <john.garry@xxxxxxxxxx> wrote: > >> > >> Some prints in the code are for a hex number, but don't prefix "0x". Add > >> the prefix, as is the norm. > > > >> - pr_err("addr %llx not registered in io_range_list\n", > >> + pr_err("addr 0x%llx not registered in io_range_list\n", > >> (unsigned long long) addr); > > > > Can we use %pa at the same time? > OK, I think that we can use %pa and drop the casting to unsigned long long. Yes, that it is the point. -- With Best Regards, Andy Shevchenko