On 3/22/19 12:31 PM, Lorenzo Pieralisi wrote: > On Sun, Feb 17, 2019 at 02:24:41PM +0100, marek.vasut@xxxxxxxxx wrote: >> From: Kazufumi Ikeda <kaz-ikeda@xxxxxxxxxxxxx> >> >> Reestablish the PCIe link very early in the resume process in case it >> went down to prevent PCI accesses from hanging the bus. Such accesses > > Hi Marek, Kazufumi, Hi, > Apologies for the delay. > > Just as a clarification, when you state "in case it went down" isn't > this supposed to happen for every suspend cycle ? Let me know and I > will add a comment to the patch commit log. It does happen on every suspend/resume cycle and if you manually put a remote endpoint into non-L0 state. >> can happen early in the PCI resume process, in the resume_noirq, thus >> the link must be reestablished in the resume_noirq callback of the >> driver. >> >> Signed-off-by: Kazufumi Ikeda <kaz-ikeda@xxxxxxxxxxxxx> >> Signed-off-by: Gaku Inami <gaku.inami.xw@xxxxxxxxxxxxxx> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> Cc: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> >> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx> >> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> >> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx > > This looks like a fix (most likely fixing initial S2R support, please > help me chase the commit ID), should we consider it for stable kernels ? > > Without it I understand S2R is actually broken on platforms with this > host bridge. I don't think this ever worked, so it's hard to find a Fixes: commit for this. -- Best regards, Marek Vasut
