On 3/18/19 9:35 AM, Geert Uytterhoeven wrote: > On Sun, Mar 17, 2019 at 1:06 AM <marek.vasut@xxxxxxxxx> wrote: >> From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >> >> The MSI address can be 64bit. Switch the data type used to hold the >> result of virt_to_phys() to phys_addr_t to reflect it's properties > > Side note: probably this should use a proper DMA API instead of > get_free_pages()/virt_to_phys(). In fact, I think it doesn't matter. The MSI message is never written into this page as an actual memory write, it is interpreted by the hardware as an interrupt when it arrives. So I believe this page is just a safety net, which is never actually written. >> correctly and program the top 32bits of PA into PCIEMSIAUR. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> [...] -- Best regards, Marek Vasut
