On Wed, Feb 27, 2019 at 08:21:58PM +0000, Alex_Gagniuc@xxxxxxxxxxxx wrote: > On 2/24/19 8:29 PM, Lukas Wunner wrote: > > On Fri, Dec 07, 2018 at 12:20:00PM -0600, Alexandru Gagniuc wrote: > > > Q: Why is this unconditionally compiled in? > > > A: The symmetrical check in pci probe() is also always compiled in. > > > > Hm, it looks like the convention is to provide a separate Kconfig entry > > for each port service. > > Does the convention still make sense in light of the symmetry reason? I don't know. In the past we had OpenWRT/LEDE folks complain that the PCI core is hogging too much memory on their space-constrained Mips routers, so they #ifdef'ed a lot of x86-specific stuff in quirks.c. In the same vein they could argue that they'd like to disable unneeded PCIe services. That space argument and possibly the reduction of attack surface on Linux firewalls is the only justification I can come up with for a separate Kconfig option for bandwidth notification. Thanks, Lukas
