Hi Lucas,
On Wed, Feb 27, 2019 at 1:53 PM Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote:
>
> Since 7c5925afbc58 (PCI: dwc: Move MSI IRQs allocation to IRQ domains
> hierarchical API) the MSI init claims one of the controller IRQs as a
> chained IRQ line for the MSI controller. On some designs, like the i.MX6,
> this line is shared with a PCIe legacy IRQ. When the line is claimed for
> the MSI domain, any device trying to use this legacy IRQs will fail to
> request this IRQ line.
>
> As MSI and legacy IRQs are already mutually exclusive on the DWC core,
> as the core won't forward any legacy IRQs once any MSI has been enabled,
> users wishing to use legacy IRQs already need to explictly disable MSI
> support (usually via the pci=nomsi kernel commandline option). To avoid
> any issues with MSI conflicting with legacy IRQs, just skip all of the
> DWC MSI initalization, including the IRQ line claim, when MSI is disabled.
Thanks for the patch.
> Fixes: c5925afbc58
> (PCI: dwc: Move MSI IRQs allocation to IRQ domains hierarchical API)
Nit: the commit ID is missing the digit 7 as the first number.
While at it, the Fixes lines should written as a single line
Fixes: 7c5925afbc58 ("PCI: dwc: Move MSI IRQs allocation to IRQ
domains hierarchical API")
The " " symbols for the commit Subject is also missing in the commit log.
