On Thu, 2019-02-21 at 18:35 +0000, Alex_Gagniuc@xxxxxxxxxxxx wrote: > On 2/21/19 1:57 AM, Lukas Wunner wrote: > > On Tue, Feb 19, 2019 at 07:20:30PM -0600, Alexandru Gagniuc wrote: > > > --- a/drivers/pci/hotplug/pciehp_hpc.c > > > > > > +} > > > + > > > +DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_PLX, 0x9733, > > > > By convention there's no blank line between the closing curly brace > > and the DECLARE_PCI_FIXUP_CLASS_FINAL(). Not completely true. See: arch/mips/pci/fixup-loongson3.c > I'm sorry for all the style issues. I realize it's noise and should just > be done right from the beginning. Is there a way to make checkpatch.pl > catch these before they go out? You could write a new rule, but it's non trivial as there are multiple consecutive uses and multi-line uses too. I think it's a rule not worth writing.