On Mon, Jan 28, 2019 at 09:49:32PM -0800, Maya Nakamura wrote: > On Sun, Jan 27, 2019 at 05:11:48AM +0000, Michael Kelley wrote: > > From: Maya Nakamura <m.maya.nakamura@xxxxxxxxx> Sent: Saturday, January 26, 2019 12:52 AM > > > > > > Remove a duplicate definition of VP set (hv_vp_set) and use the common > > > definition (hv_vpset) that is used in other places. > > > > > > Change the order of the members in struct hv_pcibus_device so that the > > > declaration of retarget_msi_interrupt_params is the last member. Struct > > > hv_vpset, which contains a flexible array, is nested two levels deep in > > > struct hv_pcibus_device via retarget_msi_interrupt_params. > > > > > > Add a comment that retarget_msi_interrupt_params should be the last member > > > of struct hv_pcibus_device. > > > > > > Signed-off-by: Maya Nakamura <m.maya.nakamura@xxxxxxxxx> > > > --- > > > Change in v2: > > > - None > > > > > > > Right -- there was no code change. But it's customary to note that > > you updated the commit message. > > > Thank you for your feedback. I will edit the change log in v3. > > > Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx> I will add Michael's tag to v3 (unless Michael is not happy with that), it is missing there. Lorenzo
