On Fri, 2019-02-15 at 15:34 +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/portdrv > head: b4f663e35a545fbdc71b3bbf2df88ef9f124a3fa > commit: b4f663e35a545fbdc71b3bbf2df88ef9f124a3fa [1/1] PCI/portdrv: Support PCIe services on subtractive decode bridges > reproduce: > # apt-get install sparse > git checkout b4f663e35a545fbdc71b3bbf2df88ef9f124a3fa > make ARCH=x86_64 allmodconfig > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > > All warnings (new ones prefixed by >>): > > >> drivers/pci/pcie/portdrv_pci.c:187:9: sparse: warning: Initializer entry defined twice > drivers/pci/pcie/portdrv_pci.c:189:9: sparse: also defined here > > sparse warnings: (new ones prefixed by >>) > > drivers/pci/pcie/portdrv_pci.c:187:9: sparse: warning: Initializer entry defined twice > >> drivers/pci/pcie/portdrv_pci.c:189:9: sparse: also defined here > > vim +187 drivers/pci/pcie/portdrv_pci.c > > ^1da177e Linus Torvalds 2005-04-16 181 > ^1da177e Linus Torvalds 2005-04-16 182 /* > ^1da177e Linus Torvalds 2005-04-16 183 * LINUX Device Driver Model > ^1da177e Linus Torvalds 2005-04-16 184 */ > ^1da177e Linus Torvalds 2005-04-16 185 static const struct pci_device_id port_pci_ids[] = { { > ^1da177e Linus Torvalds 2005-04-16 186 /* handle any PCI-Express port */ > ^1da177e Linus Torvalds 2005-04-16 @187 PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x00), ~0), > b4f663e3 Honghui Zhang 2019-02-14 188 /* subtractive decode PCI-to-PCI bridge, class type is 060401h */ > b4f663e3 Honghui Zhang 2019-02-14 @189 PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x01), ~0), > ^1da177e Linus Torvalds 2005-04-16 190 }, { /* end: all zeroes */ } > ^1da177e Linus Torvalds 2005-04-16 191 }; > ^1da177e Linus Torvalds 2005-04-16 192 > Hi, Bjorn, Do you think drop this one, and I send a new version is a good idea? Or will you re-consider the first version patch? Thanks. > :::::: The code at line 187 was first introduced by commit > :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 > > :::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx> > :::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation
