On Wed, Feb 13, 2019 at 11:31:07AM -0600, Aaron Sierra wrote: > ----- Original Message ----- > > From: "Bjorn Helgaas" <helgaas@xxxxxxxxxx> > > To: "Aaron Sierra" <asierra@xxxxxxxxxxx> > > Sent: Wednesday, January 30, 2019 4:57:53 PM > > Subject: Re: [PATCH v2 2/2] PCI/ACPI: Improve _OSC control request granularity > > > On Thu, Oct 25, 2018 at 11:01:32AM -0500, Aaron Sierra wrote: > > Then the calls would look like: > > > > control |= __osc_set_pciehp_control(root, support); > > control |= __osc_set_shpchp_control(root, support); > > ... > > Yes, I do like that better. I had a draft with that structure, but I changed > for some reason. FYI, I'm inclined to rename these bit-setting functions to > "osc_get_X_control_bits()" to try to avoid confusion. Hopefully that sits well > with you. Sounds good! Bjorn
