On Thu, 2019-02-07 at 12:31 +0000, Lorenzo Pieralisi wrote:
> + /* De-assert DCC_FB_EN */
> > + writel(PCIE_PHY_CMN_REG4_DCC_FB_EN,
> > + imx6_pcie->phy_base + PCIE_PHY_CMN_REG4);
> > + /* Assert RX_EQS and RX_EQS_SEL */
> > + writel(PCIE_PHY_CMN_REG24_RX_EQ_SEL
> > + | PCIE_PHY_CMN_REG24_RX_EQ,
> > + imx6_pcie->phy_base + PCIE_PHY_CMN_REG24);
> > + /* Assert ATT_MODE */
> > + writel(PCIE_PHY_CMN_REG26_ATT_MODE,
> > + imx6_pcie->phy_base + PCIE_PHY_CMN_REG26);
> > + } else {
> > + dev_warn(dev, "DT lacks imx7d-pcie-phy, unable to apply ERR010728 workaround\n");
>
> It is a nit but the warning log is not necessarily true ie you may not
> have a mapped address for other reasons as well. It is up to you but I
> would change the log message.
True, but I hardly want to enumerate every possible failure point in a
log message. How about:
Unable to apply ERR010728 workaround. DT lacks imx7d-pcie-phy?
