On Fri, Jan 04, 2019 at 09:49:05AM -0800, Andrey Smirnov wrote: > Everyone: > > This is the series containing various small improvements that I made > while reading the code and researching commit history of pci-imx6.c > and pcie-designware*.c files. All changes are optional, so commits > that don't seem like an improvement can be easily dropped. Hopefully > each patch is self-explanatory. Side note: You should trim the CC list, eg I do not think CC LKML is needed at all for this series. @Lucas: May I ask you to consider please which patches you deem worth for inclusion ? I will have a look too but I would be grateful if the driver maintainers can chime in to help. Thanks, Lorenzo > I tested this series on i.MX6Q, i.MX7D and i.MX8MQ. > > Feedback is welcome! > > Thanks, > Andrey Smirnov > > Changes since [v1]: > > - Dropped "PCI: imx6: Drop imx6_pcie_link_up()" due to the matter > already having been addressed by "PCI: imx6: Fix link training > status detection in link up check" from Trent Piepho > > - Changed "designware" -> "dwc" for all subject lines > > - Collected Acked-by's from Gustavo Pimentel > > [v1] lkml.kernel.org/r/20181221072716.29017-1-andrew.smirnov@xxxxxxxxx > > Andrey Smirnov (20): > PCI: imx6: Simplify imx7d_pcie_wait_for_phy_pll_lock() > PCI: imx6: Remove redundant debug tracing > PCI: imx6: Return -ETIMEOUT from imx6_pcie_wait_for_speed_change() > PCI: imx6: Remove duplicate macro definitions > PCI: imx6: Remove PCIE_PL_PFLR_* constants > PCI: imx6: Remove PCIE_PHY_RX_ASIC_OUT* constants > PCI: dwc: Make use of IS_ALIGNED() > PCI: dwc: Share code for dw_pcie_rd/wr_other_conf() > PCI: dwc: imx6: Share PHY debug register definitions > PCI: dwc: Make use of BIT() in constant definitions > PCI: imx6: Make use of BIT() in constant definitions > PCI: imx6: Simplify bit operations in PHY functions > PCI: imx6: Simplify pcie_phy_poll_ack() > PCI: imx6: Restrict PHY register data to 16-bit > PCI: imx6: Pass data to dw_pcie_writel_dbi() directly > PCI: imx6: Use common mask in imx6_pcie_reset_phy() > PCI: imx6: Simplify bit operations in imx6_setup_phy_mpll() > PCI: imx6: Remove magic numbers from imx6_pcie_establish_link() > PCI: dwc: Make use of GENMASK/FIELD_PREP > PCI: dwc: Remove superfluous shifting in definitions > > drivers/pci/controller/dwc/pci-imx6.c | 139 +++++++----------- > .../pci/controller/dwc/pcie-designware-host.c | 61 +++----- > drivers/pci/controller/dwc/pcie-designware.c | 18 +-- > drivers/pci/controller/dwc/pcie-designware.h | 60 ++++---- > 4 files changed, 115 insertions(+), 163 deletions(-) > > -- > 2.20.1 >
