Hi Gregory, Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> wrote on Fri, 18 Jan 2019 17:51:52 +0100: > Hi Miquel, > > On mar., janv. 08 2019, Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > > > Hello, > > > > As part of an effort to bring suspend to RAM support to Armada 3700 > > SoCs (main target: ESPRESSObin), this series handles the work around > > the PCIe IP. > > > > First, more configuration is done in the 'setup' helper as inspired > > from the U-Boot driver. This is needed to entirely initialize the IP > > during future resume operation (patch 1). > > > > Then, reset GPIO, PHY and clock support are introduced (patch 2-4). As > > current device trees do not provide the corresponding properties, not > > finding one of these properties is not an error and just produces a > > warning. However, if the property is present, an error during PHY > > initialization will fail the probe of the driver. > > > > Note: To be sure the clock will be resumed before this driver, a first > > series adding links between clocks and consumers has been submitted, > > see [1]. Anyway, having the clock series applied first is not needed. > > > > Patch 5 adds suspend/resume hooks, re-using all the above. > > > > Finally, bindings and device trees are updated to reflect the hardware > > (patch 6-12). While the clock depends on the SoC, the reset GPIO and > > the PHY depends on the board so the clock is added in the > > armada-37xx.dtsi file while the two other properties are added in > > armada-3720-espressobin.dts. > > > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-January/623885.html > > > > Thanks, > > Miquèl > > > > > > Changes since v2: > > ================= > > * Minor patches reordering. > > * Added pinctrl patches from Gregory Clement fixing the PCIe pins. His > > changes implied modifications in the DT/bindings patches adding PCIe > > reset pin support. > > Actually these patches are not in this series. You propably meant that > this series is depend on these patches. > > If needed, for peoaple who wanted to test this series, the pinctrl > changes are now in linux-next and also in pinctrl/for-next. Absolutely, this is what I meant, thanks for clarifying. Thanks, Miquèl
