On Fri, Dec 21, 2018 at 03:19:49PM +0100, Sebastian Ott wrote: > Hello Bjorn, > > On Thu, 20 Dec 2018, Bjorn Helgaas wrote: > > I think the strategy is fine, but can you restructure the patches > > like this: > > > > 1) Factor out sriov_add_vfs() and sriov_dev_vfs(). This makes no > > functional change at all. > > > > 2) Add dev->no_vf_scan, set it in the s390 pcibios_add_device(), and > > test it in sriov_add_vfs(), and sriov_del_vfs(). > > > > I think both pieces will be easier to review that way. > > Done. I took the liberty to add Christoph's R-b to the first two patches > since it's just a split of the patch he gave the R-b to. Thanks. It's really way too late to do this, but they're pretty trivial, and I've been out longer than expected for vacation and illness, so I applied these to pci/virtualization for v4.21. Bjorn
