Hi, On 21/12/2018 07:26, Andrey Smirnov wrote: > Everyone: > > This is the series containing various small improvements that I made > while reading the code and researching commit history of pci-imx6.c > and pcie-designware*.c files. All changes are optional, so commits > that don't seem like an improvement can be easily dropped. Hopefully > each patch is self-explanatory. > > I tested this series on i.MX6Q, i.MX7D and i.MX8MQ. > > Feedback is welcome! > > Thanks, > Andrey Smirnov > > Andrey Smirnov (21): > PCI: imx6: Simplify imx7d_pcie_wait_for_phy_pll_lock() > PCI: imx6: Remove redundant debug tracing > PCI: imx6: Return -ETIMEOUT from imx6_pcie_wait_for_speed_change() > PCI: imx6: Remove duplicate macro definitions > PCI: imx6: Remove PCIE_PL_PFLR_* constants > PCI: imx6: Remove PCIE_PHY_RX_ASIC_OUT* constants > PCI: designware: Make use of IS_ALIGNED() > PCI: designware: Share code for dw_pcie_rd/wr_other_conf() > PCI: imx6: Drop imx6_pcie_link_up() > PCI: designware: imx6: Share PHY debug register definitions > PCI: designware: Make use of BIT() in constant definitions > PCI: imx6: Make use of BIT() in constant definitions > PCI: imx6: Simplify bit operations in PHY functions > PCI: imx6: Simplify pcie_phy_poll_ack() > PCI: imx6: Restrict PHY register data to 16-bit > PCI: imx6: Pass data to dw_pcie_writel_dbi() directly > PCI: imx6: Use common mask in imx6_pcie_reset_phy() > PCI: imx6: Simplify bit operations in imx6_setup_phy_mpll() > PCI: imx6: Remove magic numbers from imx6_pcie_establish_link() > PCI: designware: Make use of GENMASK/FIELD_PREP > PCI: designware: Remove superfluous shifting in definitions s/DesignWare/dwc in all patches, please. Regards, Gustavo > > drivers/pci/controller/dwc/pci-imx6.c | 151 +++++++----------- > .../pci/controller/dwc/pcie-designware-host.c | 61 +++---- > drivers/pci/controller/dwc/pcie-designware.c | 18 +-- > drivers/pci/controller/dwc/pcie-designware.h | 60 +++---- > 4 files changed, 116 insertions(+), 174 deletions(-) >
