On 12/17/2018 1:09 AM, Andrey Smirnov wrote: > In order to avoid having potentially ever growing list of variants > that don't support methods implemented in imx6_pcie_reset_phy() and > imx6_setup_phy_mpll(), change logical checks in the to check for SoC's > that _do_ support what they implement. While at it, share the code via > a small helper function. > > +static bool imx6_pcie_has_imx6_phy(struct imx6_pcie *imx6_pcie) > +{ > + return imx6_pcie->variant == IMX6Q || > + imx6_pcie->variant == IMX6SX || > + imx6_pcie->variant == IMX6QP; > +} This would be an ideal match for adding a field inside drvdata, sadly that was part of a series which stalled: https://patchwork.kernel.org/patch/10712261/