Hello, Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote on Wed, 12 Dec 2018 11:21:40 +0100: > Add a reset-gpios property to the PCIe node. > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > index 094994a9c68e..76a508da80b9 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > @@ -46,6 +46,9 @@ > /* J9 */ > &pcie0 { > status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pcie_pins>; > + reset-gpios = <&gpiosb 3 GPIO_ACTIVE_HIGH>; > }; > > /* J6 */ While this change may be fine for platforms based on Armada 3700 SoC, it is not for the EspressoBin that has no reset GPIO for PCIe and instead uses this pin to control the Ethenet switch. I will re-send a series without this patch. I think it does not hurt to keep the previous patch adding the pinmux setting in the Armada-37xx.dtsi file even without using it, so I will drop only this patch. Thanks, Miquèl