Re: [PATCH V2] x86: Fix an issue with invalid ACPI NUMA config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/11/18 1:47 AM, Jonathan Cameron wrote:
> When the PCI code later comes along and calls acpi_get_node() for any PCI
> card below the root port, it navigates up the ACPI tree until it finds the
> _PXM value in the root port. This value is then passed to
> acpi_map_pxm_to_node().
> 
> As numa_off has not been set on x86 it tries to allocate a NUMA node, from
> the unused set, without setting up all the infrastructure that would
> normally accompany such a call. 

FWIW, this _sounds_ like the real problem here.  We're allowing an
allocation to proceed without some infrastructure that we require.
Shouldn't we be detecting that this infrastructure is not in place and
warn about *it* at least?

I'm a bit worried that this is just papering over an unknown error to
make a hang go away.  It seems a bit too far away from the root cause.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux