Re: [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjorn,

On 12/10/2018 10:54 AM, Bjorn Helgaas wrote:
> On Sat, Dec 08, 2018 at 02:49:09AM +0000, Thinh Nguyen wrote:
>> Hi Bjorn,
>>
>> On 11/6/2018 12:44 AM, Felipe Balbi wrote:
>>> Thinh Nguyen <thinh.nguyen@xxxxxxxxxxxx> writes:
>>>
>>>> ++ linux-usb
>>>> ++ Greg
>>>>
>>>> On 11/2/2018 6:47 PM, Thinh Nguyen wrote:
>>>>> Synopsys USB 3.x host HAPS platform has a class code of
>>>>> PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these
>>>>> devices should use dwc3-haps driver. Set driver_override to dwc3-haps
>>>>> for these platforms.
>>>>>
>>>>> Signed-off-by: Thinh Nguyen <thinhn@xxxxxxxxxxxx>
>>> FWIW:
>>>
>>> Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
>>>
>> Please let me know if you're ok with these 2 patches.  (This and patch
>> subject "[PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs")
> 1) Run "git log --oneline drivers/pci/quirks.c" ...
>
> 2) quirk_amd_nl_class() and quirk_netmos() do something similar in a
> different way.  quirk_amd_nl_class() in particular seems to be doing
> exactly the same thing.  I think since they're doing the same thing, they
> should do it the same way.  Would the quirk_amd_nl_class() solution work
> for you?
>
> Bjorn
>

Yes. Also, the way Netmos handling multiple devices is cleaner. I'll
incorporate the their solutions.

Thanks,
Thinh




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux