On Mon, 26 Nov 2018 16:06:54 +0000, Trent Piepho <tpiepho@xxxxxxxxxx> wrote: > > On Thu, 2018-11-22 at 16:38 +0000, Marc Zyngier wrote: > > > > To add to Lorenzo's comment, we're trying hard to have a *minimal* fix > > that can be easily backported. Changing variable and field names as well > > as flipping the semantic of other bits of the driver makes it harder to > > review, and certainly doesn't help getting things backported to stable > > (see the stable kernel rules). > > > > I'd suggest this kind of repainting is better kept as a separate patch > > and merged separately. > > If you want a minimal fix to backport, you should just use my original > patch for 4.15-4.19 stable series. It's a one line change to fix the > real bug. > > It'll be far easier to backport to < 4.17, where the hierarchical irq > domain stuff wasn't used in this part of the driver. The right fix is to create an irq_ack method and put the relevant code there. Thanks, M. -- Jazz is not dead, it just smell funny.
